apache / apache/pulsar

[Bug] Disabling entry filters isn't possible when allowOverrideEntryFilters=true and entryFilterNames is specified in broker.conf

Open
#20,520 3 comments 0 reactions 1 assignee Claimed by @nicoloboschi View on GitHub
Stale type/bug
Dominant language
Java
Stars
15.3k
Forks
3.8k
Avg merge
1d 14h
Merged PRs (30d)
160

Description

### Search before asking

- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.

### Version

3.0.x, master

### Minimal reproduce step

Disabling entry filters isn't possible when `allowOverrideEntryFilters=true` and `entryFilterNames` is specified in `broker.conf`.

### What did you expect to see?

It should be possible to disable entry filters completely at topic level when `allowOverrideEntryFilters=true`

### What did you see instead?

The `entryFilterNames` in `broker.conf` are used when the list of entry filters for the topic is empty. Please see the code:
https://github.com/apache/pulsar/blob/50b9a93e42e412d9f17b1637287d1a4c7c7ab148/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/EntryFilterSupport.java#L45-L51

### Anything else?

_No response_

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.