apache / apache/pulsar

[Bug] V4.0.1 wireshark lua script will crash

Open
#18,439 5 comments 0 reactions 0 assignees View on GitHub
Stale type/bug
Dominant language
Java
Stars
15.3k
Forks
3.8k
Avg merge
1d 14h
Merged PRs (30d)
160

Description

### Search before asking

- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.

### Version

Master version of Pulsar.

Version 4.0.1 (v4.0.1-0-ge9f3970b1527) of Wireshark.

### Minimal reproduce step

https://github.com/apache/pulsar/pull/13564 add a lua script to parse Pulsar command, which is great.

I follow the step [here](https://github.com/apache/pulsar/tree/master/wireshark).

First I put `PulsarApi.proto` file to a folder and set `protobuf search path` in wireshark:

![image](https://user-images.githubusercontent.com/37220920/201467580-96b229d6-6c38-46b7-8202-374de2e86b7f.png)

Then I copy lua script to plugin folder:

![image](https://user-images.githubusercontent.com/37220920/201467603-23e29f4a-530c-4a37-bbdb-a0ca2e994814.png)

Restart wireshark and start a pulsar standalone, I can see ping/pong message on port 6650:

image

Now, I create a producer or consumer to send or consume messages.

### What did you expect to see?

Wireshark should parse other protobuf packages just like ping/pong.

### What did you see instead?

Wireshark will crash.

### Anything else?

_No response_

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Start in the wireshark/ directory with the Lua script added by pull request #13564, and reproduce the crash using PulsarApi.proto, Wireshark, and a producer or consumer on port 6650. Compare this with the working ping/pong capture; done means Wireshark remains running and parses the other protobuf packages.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.