apache / apache/pulsar

Hbase connector does not have working tests

Open
#14,434 2 comments 0 reactions 0 assignees View on GitHub
help wanted type/enhancement
Dominant language
Java
Stars
15.3k
Forks
3.8k
Avg merge
1d 14h
Merged PRs (30d)
160

Description

**Describe the bug**

Hbase connector does not have working tests, thus its state and compatibility with various library changes is unclear.

**To Reproduce**

The only useful test (let's ignore HbaseSinkConfigTest test) is `HbaseGenericRecordSinkTest` with one test method which is disabled since the day it was committed in Jan 2019 https://github.com/apache/pulsar/pull/3368 :
https://github.com/apache/pulsar/blob/9fe2f418200f4231326fc273e5671c5536b9bf65/pulsar-io/hbase/src/test/java/org/apache/pulsar/io/hbase/sink/HbaseGenericRecordSinkTest.java#L84-L85

I tried enabling the test and running it on my mac, the test resulted in panic and MacOS crash.

Integration tests were never finished and committed: https://github.com/apache/pulsar/pull/3695

**Expected behavior**

Working set of tests covering functionality, running on CI

Contributor guide

Open the contributing guide

Research direction

Start with pulsar-io/hbase/src/test/java/org/apache/pulsar/io/hbase/sink/HbaseGenericRecordSinkTest.java, especially the disabled test noted in the issue, and review the unfinished integration-test pull request. Run the existing HBase connector tests in the project’s CI environment rather than enabling the test locally first. Done means a working test set covering connector functionality and running successfully on CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.