apache / apache/pulsar-client-node

Now that acknowledge returns a Promise, should negativeAcknowledge return a Promise too?

Open
#212 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
164
Forks
98
PR merge metrics
No merged PRs in 30d

Description

The `acknowledge` method of the `Consumer` type was [recently updated](https://github.com/apache/pulsar-client-node/pull/200) to return a `Promise`. Should the `negativeAcknowledge` method also return a `Promise`?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Consumer type's acknowledge and negativeAcknowledge methods, then read pull request #200 to understand the earlier Promise change. Determine whether negativeAcknowledge should match that API and identify the relevant implementation and tests; done means the decision is settled and any agreed API change is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.