apache / apache/pulsar-client-go

QoL improvement: MaxReconnectToBroker and BackoffPolicy UX improvements

Open
#985 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
745
Forks
389
Avg merge
3d 20h
Merged PRs (30d)
3

Description

**Is your feature request related to a problem? Please describe.**
Usability problems:
- MaxReconnectToBroker is a `*uint` for what seems to be no good reason. Pointers to primitive ints are rare and unusual in public APIs.
- BackoffPolicy conceptually controls the same things as MaxReconnectToBroker, having them separate is confusing.

**Describe the solution you'd like**
- Combine MaxReconnectToBroker and BackoffPolicy into a single policy struct that can be supplied.
- Either stop passing max-reconnects as a pointer, or document how/when it should be used as a pointer (i.e. written through).

These would be breaking public API changes, so this may be a WONTFIX on that basis.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.