apache / apache/ponymail

setup.py tries to install Python modules

Open
#465 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
80
Forks
32
PR merge metrics
No merged PRs in 30d

Description

If the import of elasticsearch fails, setup.py tries to install some Python modules.
This uses pip3 and is unconditionally tried if the current user is root.

I think this is out of scope for the setup script.
It's also potentially dangerous to run external processes as root.
Also the installation may not be using pip3.

Setup.py should report an issue if a required module is missing, but should not unconditionally install them.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading setup.py around the elasticsearch import and the conditional pip3 invocation. Confirm the setup path reports the missing required module without launching an external installation process, especially when run as root; verify the resulting behavior with the project's available setup or installation checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.