apache / apache/ponymail

Bug: code includes embedded configuration items and other 'magic' items

Open
#179 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
80
Forks
32
PR merge metrics
No merged PRs in 30d

Description

The code contains quite a few 'magic' numbers and strings which should be configuration choices.

For example, the size = 50000 parameters in preferences.lua, and the date range { gte = "now-20y" }

These values should be moved into config.lua or a similar location so they can easily be adjusted.

Code should rarely (if ever) contain 'magic' numbers or strings.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing preferences.lua and the referenced config.lua or similar configuration location, then search for other embedded numbers and strings. Move values that are intended as configuration choices into the configuration location and verify that the affected behavior can be adjusted there without changing code.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
developer-experience
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.