apache / apache/ponymail-foal

Is msg_metadata needed here?

Open
#168 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
45
Forks
23
PR merge metrics
No merged PRs in 30d

Description

https://github.com/apache/incubator-ponymail-foal/blob/a593d2eda9ea6bdafd5b3b8ca4554d233ed3165b/tools/archiver.py#L664

AFAICT, all the subsequent usages of msg_metadata could be replaced by references to ojson instead, so there does not seem to be any need for the parameter.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at tools/archiver.py around line 664 and inspect the function's msg_metadata parameter and its subsequent usages. Compare those references with ojson, then confirm that removing the unnecessary parameter leaves all remaining archiver behavior and references consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.