Broken comparison: header value is terminated with \r\n, but lid is not
Open
Beginner friendly
bug
- Dominant language
- Python
- Stars
- 45
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/apache/incubator-ponymail-foal/blob/4bbc470aab8623512f1d932e843154ec558b8648/tools/plugins/dkim_id.py#L327
As the subject says.
The code needs to be fixed, and a test added
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at tools/plugins/dkim_id.py line 327, linked in the issue, and inspect the comparison of the header value with the lid. Determine the matching line-ending behavior described in the issue, then add a regression test as requested. Done means the comparison handles the two values consistently and the new test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100