apache / apache/pinot

Reduce duplicate SQL parsing in Broker

Open
#9,025 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

SQL gets parse up to twice in brokerRequestHandler because there's 2 different endpoint to parse options and SQL into SQLNodes.

Propose to unify it and have request handler giving 2 APIs:
- one accepts JSON Request STRING;
- one accepts the parsed SQLNodeAndOption so that it doesn't get reparse.

Contributor guide

Open the contributing guide

Research direction

Start at brokerRequestHandler and trace the two endpoint paths that parse options and SQL into SQLNodes. Compare the JSON Request STRING API with the parsed SQLNodeAndOption path; done means the request handler exposes both forms without reparsing SQL.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design, databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.