apache / apache/pinot

Clean up behavior of config parsing

Open
#7,512 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

some inconsistencies were discovered after https://github.com/apache/pinot/pull/7497

For example, configuration values were parsed into Lists and then re-constructed back into String. However the return changes were not exactly desired (e.g. parsed as comma-separated string but put back together as Arrays Stringification). This prompts me to ask a question: what are the proper configuration parsing between String / Arrays and other non-primitive types.

Since our usages in pinot-spi are largely depend on apache common configuration package. we should
- add some test around our extended behavior that might or might not be different from apache common. and
- correct any inconsistent / non-desired behavior if necessary

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the configuration parsing behavior used in pinot-spi and compare it with the Apache Commons Configuration package, using PR 7497 as context. Define expected handling for String, Arrays, and other non-primitive values, then add tests for Pinot-specific behavior and correct any inconsistencies those tests expose.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.