startServiceManager() not used in StartServiceManagerCommand
- Dominant language
- Java
- Stars
- 6.1k
- Forks
- 1.5k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 195
Description
Hello - I just started looking at the code and please ignore if this issue is addressed .
It seems the startServiceManager() method in StartServiceManagerCommand is not used also am curious why it returns the instanceID when the pinotServiceManager thread wouldn't have started . Do you think it would be good to return the instance ID only once the pinotServiceManager started successfully by using the state of the isStarted() method.
Let me know what do you think and i would be intersted to work on it if you permit .
Contributor guide
Research direction
Start with StartServiceManagerCommand, locating startServiceManager() and its use of the instance ID and isStarted() state. Trace how the pinotServiceManager thread is started, then check the issue discussion for the intended behavior; done should establish and test when the instance ID may be returned.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100