apache / apache/pinot

The XXXPinotFS.isDirectory methods should return false if the provided directory doesn't exist

Open
#7,083 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

This would be consistent with how Java's `File.isDirectory()` (and `File.isFile()`) work.

Currently at least `HadoopPinotFS.isDirectory()` (don't know about others) throws a `FileNotFoundException` if called on a non-existent file/directory.

Contributor guide

Open the contributing guide

Research direction

Locate the XXXPinotFS.isDirectory implementations, especially HadoopPinotFS.isDirectory(), and compare their handling of missing paths with Java File.isDirectory(). Add or update tests covering nonexistent files and directories, then verify each implementation returns false rather than throwing FileNotFoundException.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.