apache / apache/pinot

FLOAT missing from Literal datatypes, but defined in Column datatypes.

Open
#6,814 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

FLOAT is missing from Literal datatypes (org.apache.pinot.common.request.Literal) but defined as a column datatype (org.apache.pinot.spi.data.FieldSpec.DataType). This may create type conversion issues since the only way to specify values for FLOAT column is by using DOUBLE literal values.

Literal defines the following datatypes:
BOOL, BYTE, SHORT, INT, LONG, DOUBLE, STRING, BINARY

FieldSpec.DataType defines the following datatypes:
INT, LONG, FLOAT, DOUBLE, BOOLEAN/* Stored as STRING */, STRING, BYTES, STRUCT, MAP, LIST;

Contributor guide

Open the contributing guide

Research direction

Start by reading org.apache.pinot.common.request.Literal and org.apache.pinot.spi.data.FieldSpec.DataType, then trace how literal types are converted for column values. Confirm the FLOAT datatype is represented consistently and that FLOAT column values no longer require DOUBLE literals, adding or updating relevant conversion coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.