apache / apache/pinot

Use CONSUMING and COMPLETED as Pinot Realtime Segment status enum for consistency

Open
#6,777 0 comments 0 reactions 3 assignees Claimed by @chenboat View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 3h
Merged PRs (30d)
195

Description

Today the Enum values used in realtime segment status are IN_PROGRESS and DONE.

https://github.com/apache/incubator-pinot/blob/e9170aa8e61a00032f036d6e56bf21f6bebef1e6/pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java#L392

They are inconsistent with usages elsewhere in the code base where CONSUMING is used for IN_PROGESS and COMPLETED is used for DONE.

We should deprecate IN_PROGRESS and DONE and used CONSUMING and COMPLETED instead in the new code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.