apache / apache/pinot

minion configuration don't have any prefix

Open
#6,698 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

To configure minion storage we need to provide `storage.factory.*` (see [startup](https://github.com/apache/incubator-pinot/blob/4183ffe71c19944312a99555392033cbd7481ac4/pinot-minion/src/main/java/org/apache/pinot/minion/MinionStarter.java#L164)).

But those configuration keys doesn't have the `pinot.minion` prefix like for others services (e.g. `pinot.controller.*`):
https://github.com/apache/incubator-pinot/blob/2d0d2aca7157ab23421f14f439e7792900507dd9/pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java#L356

Contributor guide

Open the contributing guide

Research direction

Start with the storage configuration use in pinot-minion/src/main/java/org/apache/pinot/minion/MinionStarter.java around the linked startup reference, then compare its keys with the service prefixes in pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java around line 356. Confirm the intended naming convention and update the minion storage keys so the documented configuration uses the pinot.minion prefix consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.