apache / apache/pinot

Fix logging dependencies in pinot-spi

Open
#6,364 3 comments 0 reactions 0 assignees View on GitHub
good first issue help wanted
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 3h
Merged PRs (30d)
195

Description

pinot-spi’s pom has a dependency on `log4j-slf4j-impl`. I don’t think this is right - it should only depend on `slf4j-api`. Because of the current dependency, the pinot-java-client’s dependency on pinot-spi pulls in the logging implementation, which is not what you want because it means an external project using the client often needs to exclude those logging jars.

I'm guessing there are other components with a similar issue - only jars that are run from the command line should have dependencies on log4j-slf4j-impl, and include log4j2 configuration resources.

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the pinot-spi pom and the dependency path from pinot-java-client. Compare other component poms for log4j-slf4j-impl and log4j2 configuration resources, then verify that library components expose only slf4j-api while command-line jars retain their logging implementation dependencies.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.