apache / apache/pinot

Controller Metric missing a critical dot in it

Open
#6,063 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

Right now the latest controller metric is missing one dot in its name, making them not easy to read:
```
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerInstanceDeleteError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerInstancePostError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerLeaderPartitionCount",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerLeadershipChangeWithoutCallback",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerRealtimeTableSegmentAssignmentError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerSchemaUploadError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerSegmentUploadError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableAddError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableSchemaUpdateError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableTenantCreateError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableTenantDeleteError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableTenantUpdateError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllercontrollerTableUpdateError",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerdataDir.exists",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerdataDir.fileOpLatencyMs",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerdisabledTableCount",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerhealthcheckBadCalls",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerhealthcheckOkCalls",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerhelix.connected",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerhelix.leader",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerhelixZookeeperReconnects",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllernumberOfReplicas.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllernumberSegmentUploadTimeoutExceeded",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllernumberTimesScheduleTasksCalled",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerofflineTableCount",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerpercentOfReplicas.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerpercentSegmentsAvailable.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerperiodicTaskNumTablesProcessed",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerpinotControllerLeader",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerpinotLeadControllerResourceEnabled",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllerrealtimeTableCount",type="ControllerMetrics"
"org.apache.pinot.common.metrics":name="pinot.controllersegmentsInErrorState.point_transaction_entry_rt_REALTIME",type="ControllerMetrics"
```
For example pinot.**controllercontrollerInstancePostError** should have a "dot" in it, making pinot.controller.controllerInstancePostError

Contributor guide

Open the contributing guide

Research direction

Start by locating the ControllerMetrics definitions that produce the listed metric names and compare their prefix construction with correctly dotted metrics. Add the missing separator so names such as pinot.controllercontrollerInstancePostError become pinot.controller.controllerInstancePostError, then verify the listed ControllerMetrics names.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.