apache / apache/pinot

GuavaOnHeapBloomFilter can be constructed with _bloomFilter as null

Open
#5,475 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 3h
Merged PRs (30d)
195

Description

https://github.com/apache/incubator-pinot/blob/a314d42e8744549e5c182383445f11c60ac4ae4a/pinot-core/src/main/java/org/apache/pinot/core/bloom/GuavaOnHeapBloomFilter.java#L37

Because of default constructor _bloomFilter becomes null.
`add` method of `GuavaOnHeapBloomFilter` will throw `NullPointerException` error.

Contributor guide

Open the contributing guide

Research direction

Start with pinot-core/src/main/java/org/apache/pinot/core/bloom/GuavaOnHeapBloomFilter.java at the referenced constructor and inspect how the add method uses _bloomFilter. Verify the behavior of a default-constructed GuavaOnHeapBloomFilter and confirm that calling add no longer throws a NullPointerException.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.