apache / apache/pinot

Re-enable QueryCompilationTest.testAggregateJoinRemove

Open
#18,224 0 comments 0 reactions 0 assignees View on GitHub
java multi-stage priority: low query testing
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 55m
Merged PRs (30d)
182

Description

### Motivation
`pinot-query-planner/src/test/java/org/apache/pinot/query/QueryCompilationTest.java` still has `@Ignore` on `testAggregateJoinRemove()`. The ignore message says the test only passes when `PRUNE_RULES` run before `BASIC_RULES`, but enabling that changes roughly 50 hard-coded plans and may introduce redundant `Project` and `Exchange` nodes.

### Scope
- Reproduce the failing planner state.
- Decide whether the rule ordering, the expected plan, or the optimization itself is wrong.
- Re-enable the test once the intended behavior is explicit.

### Notes
Observed on `upstream/master` on April 15, 2026.

Contributor guide

Open the contributing guide

Research direction

Start in pinot-query-planner/src/test/java/org/apache/pinot/query/QueryCompilationTest.java and reproduce the failure in testAggregateJoinRemove() on upstream/master. Inspect the PRUNE_RULES and BASIC_RULES ordering, the affected hard-coded plans, and any redundant Project or Exchange nodes. Done means the intended planner behavior is explicit and the test is re-enabled without unjustified plan changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.