apache / apache/pinot

Introduce reason codes in server http requests to controller

Open
#12,055 4 comments 0 reactions 1 assignee Claimed by @akg268 View on GitHub
cleanup good first issue ingestion real-time
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 3h
Merged PRs (30d)
195

Description

pinot servers send HTTP requests to the controller for posting a completed realtime segment, posting an indication that realtime segments have stopped consuming, or that the consumer could never be created.

Currently there is a reason string that is included as an argument. This is error prone. A reason code makes it easier to incorporate code for appropriate action, given a particular reason.

The con side of a reason code is that it is a bit harder to evolve. We need to be careful writing code on the controller side, since servers may send unknown reason codes. As long as we follow some careful practices, introducing reason codes should get us to a better place.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.