apache / apache/pinot

Flaky Test PinotFSSegmentUploaderTest

Open
#10,910 2 comments 0 reactions 0 assignees View on GitHub
flaky-test
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

Saw this in my PR: https://github.com/apache/pinot/actions/runs/5261333672/jobs/9509328866?pr=10895

```
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.922 s - in org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest
[INFO] org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest.testBuildCache Time elapsed: 1.201 s
[INFO] org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest.testCreateRateLimiter Time elapsed: 0.007 s
[INFO] org.apache.pinot.core.data.manager.realtime.RealtimeConsumptionRateManagerTest.testMetricEmitter Time elapsed: 0.173 s
[INFO] Running org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest
Error: OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
00:17:05.037 ERROR [PinotFSSegmentUploader] [main] Missing segment store uri. Failed to upload segment file ca980508-3706-464a-be4b-61911ea87e60 for test_REALTIME__1__0__20230614T0017Z.
00:17:05.161 WARN [PinotFSSegmentUploader] [main] Timed out waiting to upload segment: test_REALTIME__1__0__20230614T0017Z for table: test
00:17:05.296 WARN [PinotFSSegmentUploader] [main] Timed out waiting to upload segment: test_REALTIME__1__0__20230614T0017Z for table: test
Error: Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.286 s <<< FAILURE! - in org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest
Error: org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest.testNoSegmentStoreConfigured Time elapsed: 0.01 s
Error: org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest.testSegmentAlreadyExist Time elapsed: 0.132 s <<< FAILURE!
java.lang.NullPointerException: Cannot invoke "java.net.URI.toString()" because "segmentURI" is null
at org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest.testSegmentAlreadyExist(PinotFSSegmentUploaderTest.java:77)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...
```

cc: @Jackie-Jiang : should we just bump the timeout for this test? I guess it may happen if the VM this is running on is super slow

Contributor guide

Open the contributing guide

Research direction

Start with org.apache.pinot.core.data.manager.realtime.PinotFSSegmentUploaderTest, especially testSegmentAlreadyExist around line 77, and run the test repeatedly. Inspect the timeout and missing-segment-store messages in the report; done means the test no longer fails with a null segmentURI or intermittent timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.