apache / apache/pinot

[multistage] Missing Metrics like QPS

Open
#10,781 0 comments 2 reactions 0 assignees View on GitHub
metrics multi-stage
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
1d 21h
Merged PRs (30d)
189

Description

There were some metrics added for multistage queries in: https://github.com/apache/pinot/commit/70c4c5b8019b3c3b71865bde71e4899c3659082e

But there's still some work to be done. Even for some of the existing metrics like QPS, we are emitting those at table-level, so a given query would get counted for each table that is present in it, leading to an overestimation of QPS.

Creating this ticket for tracking and gathering any other requirements. We can follow-up with some quick PRs later.

- [ ] Emit Broker Response with Num Groups Limit reached metric

cc: @walterddr @vvivekiyer

Contributor guide

Open the contributing guide

Research direction

Start by reviewing commit 70c4c5b8019b3c3b71865bde71e4899c3659082e and the existing multistage metric emission paths. Determine the remaining metric requirements, including the Broker Response metric for the Num Groups Limit, and verify that QPS is not counted once per table.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.