apache / apache/pinot

Unify index validation

Open
#10,550 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 55m
Merged PRs (30d)
182

Description

Each Pinot index have their own constraints. For example, a column of type integer should not have a TEXT index and one with raw encoding should not have a FST index. These constraints are enforced in different ways around the code, which violates RAW and makes it more difficult to change these constraints (as the developer needs to know all the places where the constraint is enforced).

There are also some situations where even when the customer explicitly ask to disable some index or use some specific encoding, the presence of some specific index implies that what the customer explicitly ask is ignored.

There have been some efforts to centralize how these constraints are enforced. For example, `TableConfigUtils.validateIndexConfigs`. But now that we can add indexes, that utility method cannot cover all cases. Ideally we should extend IndexType in order to support some kind of validation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.