apache / apache/pinot

Code clean up for ServerMetrics and BrokerMetrics

Open
#10,296 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.1k
Forks
1.5k
Avg merge
2d 55m
Merged PRs (30d)
182

Description

As part of https://github.com/apache/pinot/pull/10171 and https://github.com/apache/pinot/issues/9055 on query killing we have added registration point of metrics to BrokerMetrics and ServerMetrics, so that we don't pass down the actual metric instance to accountant code. Now we can do the refactoring for other parts of the code similarly.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing pull request 10171 and issue 9055, then trace the registration points in ServerMetrics and BrokerMetrics. Identify the other accountant-related paths that still pass metric instances directly. Done means those paths follow the same registration approach, with the relevant existing tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.