review Java usage of ActorSystem
- Dominant language
- Scala
- Stars
- 1.6k
- Forks
- 211
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 89
Description
See https://github.com/apache/pekko/pull/1419#issuecomment-2308390446
terminate() returns a Scala Future
In theory, users can ignore the return value from terminate() and call this:
https://pekko.apache.org/japi/pekko/current/org/apache/pekko/actor/ActorSystem.html#getWhenTerminated()
Maybe, we could also add `terminateWithCompletionStage` that returns `CompletionStage`?
Interestingly, the actor-typed ActorSystem has a `void` return type on `terminate()`.
You have https://pekko.apache.org/japi/pekko/current/org/apache/pekko/actor/typed/ActorSystem.html#getWhenTerminated() for Java users.
Contributor guide
Research direction
Start with the linked pull request comment and compare the classic and typed ActorSystem Java API documentation, especially terminate() and getWhenTerminated(). Determine the intended Java-facing API change and document a concrete decision, including whether a CompletionStage-returning method is required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, scala
- Domain
- api, distributed-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100