fail PekkoDiscoveryNameResolver on invalid addresses
- Dominant language
- Scala
- Stars
- 55
- Forks
- 30
- Avg merge
- 23h 12m
- Merged PRs (30d)
- 34
Description
`ResolvedTarget` has an `address: Option[InetAddress]`. `PekkoDiscoveryNameResolver` uses that, even when its `.getAddress` returns `null`. It would probably be better to fail early and treat this the same as a target with a host without an address that fails to resolve?
(if we change this we probably need to adapt some tests around balancing to test with 'valid but non-responsive' addresses rather than 'invalid' addresses)
Contributor guide
Research direction
Search for PekkoDiscoveryNameResolver and ResolvedTarget, then inspect the resolver path that handles a null getAddress result and the balancing tests mentioned in the issue. Confirm the desired behavior for invalid addresses and adapt coverage to use valid but non-responsive addresses where appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- grpc, scala
- Domain
- backend-api-design, networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100