apache / apache/parquet-java

ParquetWriter/ParquetReader should parse options directly from supplied Configuration

Open
#2,816 0 comments 0 reactions 0 assignees View on GitHub
Component: Parquet Priority: Minor Type: enhancement
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

As a Parquet user, my expectation is that ParquetWriter/ParquetReader will automatically parse any options passed in the supplied Configuration. For example:

 

```

Configuration conf = new Configuration();
conf.setBoolean(ParquetOutputFormat.BLOOM_FILTER_ENABLED, true);

ParquetWriter writer = AvroParquetWriter.builder(path)
.withSchema(Car.SCHEMA$)
.withConf(conf)
.build();

```

 

However, the above code results in a ParquetWriter where `bloomFilterEnabled` is set to false-the expected way to configure this is to use `ParquetWriter#withBloomFilterEnabled` directly.

 

IMO, when `ParquetWriter#withConf` is invoked, it should also delegate to `encodingPropsBuilder` and set any Configured properties.

**Reporter**: [Claire McGinty](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=clairemcginty) / @clairemcginty
#### PRs and other links:
- [GitHub Pull Request #1157](https://github.com/apache/parquet-mr/pull/1157)

**Note**: *This issue was originally created as [PARQUET-2351](https://issues.apache.org/jira/browse/PARQUET-2351). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.