apache / apache/parquet-java

Exception thrown by AvroParquetWriter#write causes all subsequent calls to it to fail

Open
#2,509 5 comments 0 reactions 0 assignees View on GitHub
Component: Avro Component: Parquet Priority: Major Type: bug
Dominant language
Java
Stars
3.1k
Forks
1.6k
Avg merge
3d 12h
Merged PRs (30d)
33

Description

Please see sample code below:
```java

Schema schema = new Schema.Parser().parse("""
{
"type": "record",
"name": "person",
"fields": [
{
"name": "address",
"type": [
"null",
{
"type": "array",
"items": "string"
}
],
"default": null
}
]
}
"""
);

ParquetWriter writer = AvroParquetWriter.builder(new org.apache.hadoop.fs.Path("/tmp/person.parquet"))
.withSchema(schema)
.build();

try {
// To trigger exception, add array with null element.
writer.write(new GenericRecordBuilder(schema).set("address", Arrays.asList("first", null, "last")).build());
} catch (Exception e) {
e.printStackTrace(); // "java.lang.NullPointerException: Array contains a null element at 1"
}

try {
// At this point all future calls to writer.write will fail
writer.write(new GenericRecordBuilder(schema).set("address", Arrays.asList("foo", "bar")).build());
} catch (Exception e) {
e.printStackTrace(); // "org.apache.parquet.io.InvalidRecordException: 1(r) > 0 ( schema r)"
}

writer.close();
```
It seems to me this is caused by state not being reset between writes. Is this the indented behavior of the writer? And if so, does one have to create a new writer whenever a write fails?

I'm able to reproduce this using both parquet 1.8.3 and 1.11.0, and have attached a sample parquet file for each version.

**Reporter**: [Øyvind Strømmen](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=InsulaVentus)
#### Original Issue Attachments:
- [person1_11_0.parquet](https://issues.apache.org/jira/secure/attachment/13008167/person1_11_0.parquet)
- [person1_8_3.parquet](https://issues.apache.org/jira/secure/attachment/13008168/person1_8_3.parquet)

**Note**: *This issue was originally created as [PARQUET-1887](https://issues.apache.org/jira/browse/PARQUET-1887). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.