Remove slf4j-log4j12 Binding from parquet-protobuf Module
- Dominant language
- Java
- Stars
- 3.1k
- Forks
- 1.6k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 33
Description
```none
Running org.apache.parquet.proto.ProtoInputOutputFormatTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/m2/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/m2/org/slf4j/slf4j-simple/1.7.22/slf4j-simple-1.7.22.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
```
There are two bindings being included and it produces this warning. `slf4j-log4j12` is coming in as a transient dependency. There is also a log4j properties file in the test resources, but all it does is produce logging to the console. Just stick with the `slf4j-simple` logger for testing (which is already explicitly specified for testing)
**Reporter**: [David Mollitor](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=belugabehr) / @belugabehr
**Assignee**: [David Mollitor](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=belugabehr) / @belugabehr
#### PRs and other links:
- [GitHub Pull Request #737](https://github.com/apache/parquet-mr/pull/737)
**Note**: *This issue was originally created as [PARQUET-1752](https://issues.apache.org/jira/browse/PARQUET-1752). Please see the [migration documentation](https://issues.apache.org/jira/browse/PARQUET-2502) for further details.*
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect the parquet-protobuf module's dependency configuration and test resources, including the log4j properties file mentioned in the issue. Run org.apache.parquet.proto.ProtoInputOutputFormatTest and verify that only the explicitly selected slf4j-simple binding remains and the multiple-binding warning is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100