apache / apache/paimon-trino

read time calculation error in DirectTrinoPageSource

Open
#83 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
47
Forks
55
PR merge metrics
No merged PRs in 30d

Description

DirectTrinoPageSource contains server ConnectorPageSource Reader, so it's read time shoud be a value accumulated by all ConnectorPageSource.

Otherwise, a negative relative read time will be calculated out by caller, because the caller in trino accumlates the read time by difference of pre(readtime) and current(readtime), if current ConnectorPageSource changed, it may be return a less read time, it will cause a check non-negative error and calculate incorrection

![image](https://github.com/user-attachments/assets/d17f120d-bbf6-4410-b8f3-93e6b408b850)

PR:https://github.com/apache/paimon-trino/pull/82

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.