apache / apache/ozhera

Please review WriterTest (many issues)

Open
#534 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
122
Forks
46
Avg merge
11h 56m
Merged PRs (30d)
9

Description

https://github.com/apache/ozhera/blob/66402b2a2b33712fa060efe7aa2f254bb32922cb/trace-etl/trace-etl-server/src/test/java/com/xiaomi/youpin/trace/etl/test/WriterTest.java

* not in an org.apache package
* has an `@author` tag - this is not the Apache Way - code is owned by all contributors, noone should claim credit as the author
* the test has lots of System.outs - this is not usually regarded as a good idea
* not many asserts - really doesn't seem to test much
* lines that have just `;` -- leave them blank (eg line 117)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.