apache / apache/openwhisk

"Too many concurrent requests in flight" error message is misleading

Open
#4,798 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Scala
Stars
6.8k
Forks
1.2k
Avg merge
2d 14h
Merged PRs (30d)
2

Description

@ali-raza-tariq commented on [Fri Jan 10 2020](https://github.com/apache/openwhisk-deploy-kube/issues/573)

The existing implementation shows the following error message when inflight limit is exceeded
```
b'{\n "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'
```
Few suggestions:

The message is misleading because the `allowed` should show the existing `actionInvokesConcurrent` limit set by the user (in this case 1000- which got diluted to 1200-`20% increase`, because of more than 1 controller in deployment)

So either it should mention `allowed per controller`, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)

Also, It think it would be better to change the `count` to something more meaningful like `currently running` for easy debugging. (good first issue label)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.