apache / apache/openwhisk

TransactionId.started should always be paired with TransactionId.finished

Open
#3,499 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
6.8k
Forks
1.2k
Avg merge
2d 14h
Merged PRs (30d)
2

Description

## Steps to reproduce the issue:

1. e.g. InvokerReactive has `val start = transid.started(this, LoggingMarkers.INVOKER_ACTIVATION, logLevel = InfoLevel)`
2. `start` is never used, and transid.finished(start) is never called (nor is transid.failure)
3. searching for usages of TransactionId.started && TransactionId.finished - I think each `started` should have at least one `finished` (possibly multiple? possibly `failed` as well)

*This may be isolated to InvokerReactive, not sure*

## Provide the expected results and outputs:

For any start, there should be a finish (or failure)
## Provide the actual results and outputs:

this seems like only a started:
```[InvokerReactive] [marker:invoker_activation_start:7]```
(no finished, no failure seen in logs)

## Additional information you deem important:
* This may be complicated by "started" and "finished" having different log levels - though for `LoggingMarkers.INVOKER_ACTIVATION` I think this is a missing finished+failure
* It would be good to review and be consistent on started/finished/failure log levels: i.e. all started are `DEBUG` level, all finished are `INFO` level, all failure are `WARN` level

WDYT @vvraskin ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.