apache / apache/openwhisk-wskdeploy

Test file not being used "deployment_data_action_with_inputs_outputs.yaml"

Open
#613 0 comments 0 reactions 0 assignees View on GitHub
priority: low question tests: unit
Dominant language
Go
Stars
75
Forks
73
PR merge metrics
No merged PRs in 30d

Description

The test file: tests/dat/deployment_data_action_with_inputs_outputs.yaml

does not parse correctly (not sure why it clearly uses YAML ordered array lists):
```
Error: manifestreader.go [50]: Invalid input of Yaml file
==> manifest_parser.go [98]: Failed to parse the yaml file: tests/dat/deployment_data_action_with_inputs_outputs.yaml:
====> yaml: unmarshal errors:
====> (on or near) line 4: cannot unmarshal !!seq into parsers.Package
====> (on or near) line 27: cannot unmarshal !!str `Apache-2.0` into parsers.Package
====> (on or near) line 28: cannot unmarshal !!str `helloworld` into parsers.Package
====> (on or near) line 29: cannot unmarshal !!float `1.0` into parsers.Package
```

it appears to be referenced in any unit test:
```
$ grep -r "data_action" . --include=*.go
./utils/misc_test.go:var testfile = "../tests/dat/deployment_data_action_with_inputs_outputs.yaml"
```

which is used in the test "**_TestLocalReader_ReadLocal_**"... is this a meaningful test?

Note: we do need a more feature-rich Action test IMO, that is one that uses a majority of the fields and uses inputs, outputs, runtime, version,

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.