apache / apache/openwhisk-wskdeploy

Preview Mode - alignment/format of Package and its fields is not correct

Open
#524 2 comments 0 reactions 1 assignee Claimed by @daisy-ycguo View on GitHub
enhancement priority: medium
Dominant language
Go
Stars
75
Forks
73
PR merge metrics
No merged PRs in 30d

Description

What I saw:
```
Packages:
Name: hello_world_package
bindings:

* action: hello_world
bindings:
annotations:

Triggers:

Rules

Do you really want to deploy this? (y/N):
```

what I expected:
```
---
Packages:
name: hello_world_package
bindings:
Actions:
* action: hello_world
bindings:
annotations:
Triggers:

Rules:

---

Do you really want to deploy this package? (y/N):
```
This includes:
- Proper indentation under Package
- no extra lines
- Use '' as positive feedback saying we found no actions/triggers/etc. for this package.

Also, for "packages" (plural), we should ask:
```
Do you really want to deploy these packages? (y/N):
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.