apache / apache/openwhisk-wskdeploy

Should move towards function for creating Dependent Packages?

Open
#427 2 comments 0 reactions 0 assignees View on GitHub
enhancement priority: low
Dominant language
Go
Stars
75
Forks
73
PR merge metrics
No merged PRs in 30d

Description

we recently standardized on `function` deprecating `location` for specifying source location of action code/files. Should we follow the same path for dependent packages? Dependent packages still use `location`:

```
package:
name: TestGitHubDependency
dependencies:
openwhisk-app:
location: github.com/pritidesai/openwhisk-app
```

We don't have support for `function` today, `wskdeploy` fails with:

```
package:
name: TestGitHubDependency
dependencies:
openwhisk-app:
function: github.com/pritidesai/openwhisk-app
```

Failure:

```
go test ./tests/src/integration/dependency/ -tags=integration -run=TestDependency -v
=== RUN TestDependency
wskdeploy.Path is wskdeploy
==> Executing: wskdeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/dependency/manifest.yaml -d
==> Output: 2017/08/30 01:01:48 Unmarshal Openwhisk info from internet
2017/08/30 01:01:48 The URL is https://openwhisk.ng.bluemix.net/api, selected from .wskprops
2017/08/30 01:01:48 The auth key is set, selected from .wskprops
2017/08/30 01:01:48 The namespace is ****, selected from .wskprops
2017/08/30 01:01:48 Deploying package TestGitHubDependency ...
2017/08/30 01:01:48 Done!
Done!
Done!
Deploying rule rule2 ... 2017/08/30 01:01:48 Got error creating rule with error message: The requested resource does not exist. (code 40237943) and error code: 148.
2017/08/30 01:01:48 Got error activating rule with error message: The requested resource does not exist. (code 40237946) and error code: 148.
Done!
Deploying rule rule1 ... 2017/08/30 01:01:49 Got error creating rule with error message: The requested resource does not exist. (code 40237959) and error code: 148.
2017/08/30 01:01:49 Got error activating rule with error message: The requested resource does not exist. (code 40237969) and error code: 148.
Done!
2017/08/30 01:01:49
Deployment completed successfully.

wskdeploy.Path is wskdeploy
==> Executing: wskdeploy undeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/dependency/manifest.yaml -d
==> Output: 2017/08/30 01:01:49 Unmarshal Openwhisk info from internet
2017/08/30 01:01:49 The URL is https://openwhisk.ng.bluemix.net/api, selected from .wskprops
2017/08/30 01:01:49 The auth key is set, selected from .wskprops
2017/08/30 01:01:49 The namespace is **** selected from .wskprops
Removing trigger trigger1 ... Done!
Removing trigger trigger2 ... Done!
Removing rule rule2 ... 2017/08/30 01:01:49 Got error deleting rule with error message: The requested resource does not exist. (code 40238025) and error code: 148.
Removing rule rule1 ... 2017/08/30 01:01:50 Got error deleting rule with error message: The requested resource does not exist. (code 40238031) and error code: 148.
Removing package TestGitHubDependency ... Done!

Deployment removed successfully.

--- PASS: TestDependency (2.45s)
PASS
ok github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/dependency 2.471s
```

If we decide to standardize on `function`, we will have to change code and spec.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.