apache / apache/openwhisk-utilities

Add golint to scanCode.py

Open
#20 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
6
Forks
12
PR merge metrics
No merged PRs in 30d

Description

@mrutkows commented on [Tue May 09 2017](https://github.com/apache/incubator-openwhisk/issues/2222)

the openwhisk-cli repo. added "golint" to its specific travis (see https://github.com/apache/incubator-openwhisk-cli/pull/41/files)...

Would be better to catch any formatting/syntax-related errors or warnings for .go files uniformly in scanCode.py so it is uniformly applied to all .go in all repos. (and configurable).

example Travis inclusion:
before_test:
+ - go get -u github.com/golang/lint/golint
+ - go get -d -t ./...

---

@markusthoemmes commented on [Tue May 09 2017](https://github.com/apache/incubator-openwhisk/issues/2222#issuecomment-300177064)

Is this still relevant once the CLI moves out of this repository?

---

@rabbah commented on [Wed Jun 21 2017](https://github.com/apache/incubator-openwhisk/issues/2222#issuecomment-310261703)

@mrutkows seems like this can move to the new utils repo?

Contributor guide

Open the contributing guide

Research direction

Start by locating scanCode.py in the openwhisk-utilities repository and reviewing how its checks are configured. Compare the referenced openwhisk-cli Travis inclusion for golint, then determine how a uniform, configurable Go check would fit. Done means all applicable Go repositories receive the check through the shared utility.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, python
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.