apache / apache/openwhisk-devtools

Do not clean dangling volumes that are not created by incubator-openwhisk-devtools without warning on make destroy

Open
#184 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
181
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Took this repo out for a spin. make quick-start, tested some things, make destroy. Behold, all my persistent docker volumes used in other development projects to persist data / database contents were deleted without a warning.

The line responsible for this is https://github.com/apache/incubator-openwhisk-devtools/blob/master/docker-compose/Makefile#L306

Either make sure not to "clean up" volumes that are not created by incubator-openwhisk-devtools or at least warn/ask before "cleaning" all these volumes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.