apache / apache/openwhisk-deploy-kube

values not being respect in values.yaml file

Open
#784 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
309
Forks
231
PR merge metrics
No merged PRs in 30d

Description

We have noticed five instances of incorrect helming in your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from [trivy-operator#729](https://github.com/aquasecurity/trivy-operator/issues/729) regarding the incorrect helming defect.

[grafana.imagePullPolicy](https://github.com/apache/openwhisk-deploy-kube/blob/108f327580f04c51dc4b29ac0beff024cfd6f2f9/helm/openwhisk/values.yaml#L412), [elasticsearch.service.type](https://github.com/apache/openwhisk-deploy-kube/blob/108f327580f04c51dc4b29ac0beff024cfd6f2f9/helm/openwhisk/values.yaml#L686C5-L686C9), [elasticsearch.service.nodePort](https://github.com/apache/openwhisk-deploy-kube/blob/108f327580f04c51dc4b29ac0beff024cfd6f2f9/helm/openwhisk/values.yaml#L687), [elasticsearch.service.loadBalancerIP](https://github.com/apache/openwhisk-deploy-kube/blob/108f327580f04c51dc4b29ac0beff024cfd6f2f9/helm/openwhisk/values.yaml#L691), and [elasticsearch.service.loadBalancerSourceRanges](https://github.com/apache/openwhisk-deploy-kube/blob/108f327580f04c51dc4b29ac0beff024cfd6f2f9/helm/openwhisk/values.yaml#L692) are not take affect when change their values to others. This is due to missing implementation for this value in grafana-pod.yaml file:

https://github.com/apache/openwhisk-deploy-kube/blob/5a5a2168c9c0342c026ca137f96fa9d2c8ae2748/helm/openwhisk/templates/grafana-pod.yaml#L65

and elasticsearch-svc.yaml:

https://github.com/apache/openwhisk-deploy-kube/blob/5a5a2168c9c0342c026ca137f96fa9d2c8ae2748/helm/openwhisk/templates/elasticsearch-svc.yaml#L32-L37

## Expected Behavior

These values should take affect when changing them or delete them from values.yaml file

## Actual Behavior

All values mentioned in this issue are not being respect.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.