apache / apache/openwhisk-deploy-kube
Missing liveness and readiness probes in all components
- Dominant language
- Shell
- Stars
- 309
- Forks
- 231
- PR merge metrics
- No merged PRs in 30d
Description
It seems as if the *livenessProbe* and *readinessProbe* is missing for several components:
The controller is missing the *readinessProbe*, which causes issues with rolling updates. With 1 replica, the observed behaviour is that the controller becomes unavailable for a long time since Kubernetes has no way of knowing when the new pod is ready, thereby killing off the predesessor while the new one is still in init.
All other components are missing both the *readinessProbe* and the *livenessProbe*, so similar problems with rolling updates could be an issue with thos. Since it's a good practice to have these probes, they should be added.
Contributor guide
Assessment
This issue has not been assessed yet.