apache / apache/openwhisk-cli

Upgrade SSL lib to avoid deprecated problem

Open
#518 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
109
Forks
98
PR merge metrics
No merged PRs in 30d

Description

If removed `-Xfatal-warnings` from settings.gradle, `WskCliActivationTests` test case would be successful.
But if kept `-Xfatal-warnings` in settings.gradle, `WskCliActivationTests` test case would be failed. e.g.
```
./gradlew --console=plain :tests:test --tests="system.basic.WskCliActivationTests"
> Task :tests:compileTestScala
[Error] /home/travis/gopath/src/github.com/apache/openwhisk-cli/tests/src/test/scala/system/basic/HttpProxy.scala:97: object AkkaSSLConfig in package akka is deprecated (since 2.6.0): Use Tcp and TLS with SSLEngine parameters instead. Setup the SSLEngine with needed parameters.
[Error] /home/travis/gopath/src/github.com/apache/openwhisk-cli/tests/src/test/scala/system/basic/HttpProxy.scala:102: constructor HttpsConnectionContext in class HttpsConnectionContext is deprecated (since 10.2.0): prefer ConnectionContext.httpsClient or ConnectionContext.httpsServer
two errors found

> Task :tests:compileTestScala FAILED
```
Anaway, `-Xfatal-warnings` (Warnings as errors) is userful, so we should upgrade the lib to fix it with `-Xfatal-warnings`, refer to: https://github.com/apache/openwhisk-cli/pull/517#discussion_r957031960

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.