apache / apache/nuttx

CC01 Wireless Driver Missing nxsem_post in case of error

Open
#6,009 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

At line 570:
https://github.com/apache/incubator-nuttx/blob/8d66dbc0680cb81f91674ace814b2b8a94c49cd2/drivers/wireless/cc1101.c#L568-L575

dev->devsem is not released before exiting.

Contributor guide

Open the contributing guide

Research direction

Start at drivers/wireless/cc1101.c around lines 568-575 using the linked revision, and trace the error path after dev->devsem is acquired. Confirm that the semaphore is released before that path exits, then verify the driver still builds and the error path no longer leaves the device semaphore held.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.