nxstyle: header files that are not header files.
Open
Community: Question
Type: Bug
- Dominant language
- C
- Stars
- 4k
- Forks
- 1.7k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 237
Description
There is an issue with the graphics/nxglib/nxglib_fillrun.h header file (and probably others).
It is not really a header file. It is a "template" of a C file that is included with some definitions to make a complete C file. So it will NOT pass the tests for a header file.
See:
graphics/nxglib/lcd/nxglib_fillrectangle.c
graphics/nxglib/lcd/nxglib_filltrapezoid.c
It is not clear how this case should be handled. I believe we either have change the file name extension (but then it won't be checked at all) or change the extension to .c (which is misleading too).
Reference: PR #478
Contributor guide
Assessment
This issue has not been assessed yet.