usbhost: hid_parser.c is compiled unconditionally and is possibly dead code
Open
- Dominant language
- C
- Stars
- 4k
- Forks
- 1.7k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 237
Description
in [usbhost/Make.defs](https://github.com/apache/incubator-nuttx/blob/master/drivers/usbhost/Make.defs) hid_parser.c is added to CSRCS before ifeq ($(CONFIG_USBHOST),y) so it is always compiled, no matter if USB is used or not.
It seems that the functions are not used by any code that is publicly available.
So just moving it inside the CONFIG_USBHOST block is probably not the right thing/fix.
Maybe another config option should be added? Does anyone know where the code is used?
Contributor guide
Assessment
This issue has not been assessed yet.