apache / apache/nuttx

LOW-RES FRAMEBUFFER RENDERING

Open
#3,414 0 comments 0 reactions 0 assignees View on GitHub
Type: Migrated TODO
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

```
Description: There are obvious issues in the low-res, < 8 BPP, implementation of
the framebuffer rendering logic of graphics/nxglib/fb. I see two
obvious problems in reviewing nxglib_copyrectangle():

1. The masking logic might work 1 BPP, but is insufficient for other
resolutions like 2-BPP and 4-BPP.
2. The use of lnlen will not handle multiple bits per pixel. It
would need to be converted to a byte count.

The function PDC_copy_glyph() in the file apps/graphics/pdcurs34/nuttx/pdcdisp.c
derives from nxglib_copyrectangle() and all of those issues have been
resolved in that file.

Other framebuffer rendering functions probably have similar issues.
Status: Open
Priority: Low. It is not surprising that there would be bugs in this logic:
I have never encountered a hardware framebuffer with sub-byte pixel
depth. If such a beast ever shows up, then this priority would be
higher.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.