[BUG] SDIO `callbackenable` should only exist if HPWORK queue support is enabled
- Dominant language
- C
- Stars
- 4k
- Forks
- 1.7k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 237
Description
### Description / Steps to reproduce the issue
The `callbackenable` function prototype exists outside of the ifdef guards for HPWORK queue support in include/nuttx/sdio.h.
However, this function is meant to enable the callback function that was registered earlier based on some events. I don't see why this should exist without the work queue, since without the work queue no callback can even be registered. This means the system is enabling nothing. All callback-related functions should not exist without work queue support.
### On which OS does this issue occur?
[OS: Linux]
### What is the version of your OS?
Arch Linux
### NuttX Version
master
### Issue Architecture
[Arch: all]
### Issue Area
[Area: Drivers]
### Host information
N/A
### Verification
- [x] I have verified before submitting the report.
Contributor guide
Research direction
Start in include/nuttx/sdio.h and inspect the HPWORK queue guards around the SDIO callback-related declarations, including callbackenable. Ensure these declarations are unavailable when HPWORK support is disabled, then verify the header across configurations with and without work queue support.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 75/100