apache / apache/nuttx

[BUG] Default configuration values hardcoded in code

Open
#16,420 4 comments 2 reactions 0 assignees View on GitHub
Arch: all Area: Configuring OS: Linux Type: Bug
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

### Description / Steps to reproduce the issue

There are many places in NuttX where configuration defaults are set in the source code, not from Kconfig.

This should be handled by Kconfig only otherwise it can lead to hard to detect problems like in this issue https://github.com/apache/nuttx/issues/16256

We can find these definitions using simple commands:
- `git grep "#define CONFIG"`
- `git grep " # define CONFIG"`
- `git grep " #define CONFIG"`

Some results returned in this way are false positives, so additional verification is required.

In some way the problem is related to this issue https://github.com/apache/nuttx/issues/11637

Another related problem is the use of `#define CONFIG_` for definitions that don't come from Kconfig. Shouldn't definitions in this format be reserved for Kconfig only? When I see `CONFIG_XXX_YYY` definition used somewhere in the code I expect it to be defined in `.config` / `include/nuttx/config.h`, which is often not true in NuttX.

### On which OS does this issue occur?

[OS: Linux]

### What is the version of your OS?

-

### NuttX Version

-

### Issue Architecture

[Arch: all]

### Issue Area

[Area: Configuring]

### Host information

_No response_

### Verification

- [x] I have verified before submitting the report.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.