apache / apache/nuttx

[BUG] RP23XX "Return board unique ID" feature is broken

Open
#15,666 2 comments 0 reactions 1 assignee Claimed by @linguini1 View on GitHub
Arch: arm Area: Board support OS: Linux Type: Bug
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

### Description / Steps to reproduce the issue

Select any RP23XX board.
Enable Board Selection/Return board unique ID.
We have 2 problems:
1) Wrong include
https://github.com/apache/nuttx/blob/801cd455ef4b2b7532618474becad2de92d25b65/boards/arm/rp23xx/common/src/rp23xx_uniqueid.c#L32

2) Fixing the include (should be rp23xx_pico.h ?) compilation fails with:
LD: nuttx
arm-none-eabi-ld: /home/paolo/projects/tmp/nuttx/staging/libboard.a(rp23xx_uniqueid.o): in function `rom_func_lookup':
undefined reference to `pico_processor_state_is_nonsecure'

Just for testing I pasted the pico_processor_state_is_nonsecure function definition from the pico sdk in arch/arm/src/rp23xx/rp23xx_rom.h and everything seems to work fine.

### On which OS does this issue occur?

[OS: Linux]

### What is the version of your OS?

ubuntu 24.04

### NuttX Version

master

### Issue Architecture

[Arch: arm]

### Issue Area

[Area: Board support]

### Host information

_No response_

### Verification

- [x] I have verified before submitting the report.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.