apache / apache/nuttx

[BUG] Compile warning due to __CONCAT redefinition

Open
#13,562 2 comments 0 reactions 1 assignee Claimed by @GUIDINGLI View on GitHub
Arch: arm Area: Board support
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

### Description / Steps to reproduce the issue

Perhaps due to me upgrading my arm gcc cross compiler recently, I'm seeing a compiler warning because of the definition of __CONCAT - in my case this is in _sama5d2x_memorymap.h but it occurs in 12 other files too

The warning is:
```
arm-gnu-toolchain-13.2.1-arm-none-eabi/arm-none-eabi/include/sys/cdefs.h:166: note: this is the location of the previous definition
166 | #define __CONCAT(x,y) __CONCAT1(x,y)
```
I can fix this as follows but have no idea if a better, more global fix is needed and, if so, where/how?
```
#ifndef __CONCAT
# define __CONCAT(a,b) a ## b
#endif
```

### On which OS does this issue occur?

[OS: Linux]

### What is the version of your OS?

Ubuntu 22.04.5 LTS

### NuttX Version

Master

### Issue Architecture

[Arch: arm]

### Issue Area

[Area: Board support]

### Verification

- [X] I have verified before submitting the report.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.